Skip to content

update to use viskores 1.1.1 #1692

Merged
cyrush merged 33 commits into
developfrom
task/2026_04_09_update_viskores_1.1.0
May 30, 2026
Merged

update to use viskores 1.1.1 #1692
cyrush merged 33 commits into
developfrom
task/2026_04_09_update_viskores_1.1.0

Conversation

@nicolemarsaglia

Copy link
Copy Markdown
Contributor

Requires a patch for viskores to fix a bug involving pseudocolor plots that are using control points and becoming volume renders, the annotation boundary would overwrite the data.

Viskores changed their depth buffer to track and advance the ray step/traversal and we need a depth buffer to keep track of the depth of the first hit of a ray.

@cyrush cyrush added this to the 0.9.6 milestone Apr 16, 2026
@cyrush

cyrush commented May 13, 2026

Copy link
Copy Markdown
Member

Something is different on windows with this new version, we hitting a linker limit:

 LINK : fatal error LNK1189: library limit of 65535 objects exceeded [

@cyrush cyrush changed the title update to use viskores 1.1.0 update to use viskores 1.1.1 May 14, 2026
@cyrush

cyrush commented May 19, 2026

Copy link
Copy Markdown
Member

@nicolemarsaglia
it looks like the patch process is failing after that patch was removed, any ideas?

**** Downloading /home/runner/work/ascent/ascent/source/v1.1.1.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 14.3M    0 14.3M    0     0  10.8M      0 --:--:--  0:00:01 --:--:-- 14.1M
100 16.3M    0 16.3M    0     0  10.1M      0 --:--:--  0:00:01 --:--:-- 12.5M
**** Extracting /home/runner/work/ascent/ascent/source/v1.1.1.tar.gz
**** Applying Patches to /home/runner/work/ascent/ascent/source/v1.1.1.tar.gz
patching file viskores/rendering/raytracing/Camera.cxx
patching file viskores/rendering/raytracing/Camera.h
patching file viskores/rendering/CanvasRayTracer.cxx
patching file viskores/rendering/MapperVolume.cxx
patching file viskores/rendering/MapperWireframer.cxx
patching file viskores/rendering/Wireframer.h
Hunk #6 FAILED at 525.
1 out of 6 hunks FAILED -- saving rejects to file viskores/rendering/Wireframer.h.rej
Error: Process completed with exit code 1.

@nicolemarsaglia

Copy link
Copy Markdown
Contributor Author

@nicolemarsaglia it looks like the patch process is failing after that patch was removed, any ideas?

**** Downloading /home/runner/work/ascent/ascent/source/v1.1.1.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 14.3M    0 14.3M    0     0  10.8M      0 --:--:--  0:00:01 --:--:-- 14.1M
100 16.3M    0 16.3M    0     0  10.1M      0 --:--:--  0:00:01 --:--:-- 12.5M
**** Extracting /home/runner/work/ascent/ascent/source/v1.1.1.tar.gz
**** Applying Patches to /home/runner/work/ascent/ascent/source/v1.1.1.tar.gz
patching file viskores/rendering/raytracing/Camera.cxx
patching file viskores/rendering/raytracing/Camera.h
patching file viskores/rendering/CanvasRayTracer.cxx
patching file viskores/rendering/MapperVolume.cxx
patching file viskores/rendering/MapperWireframer.cxx
patching file viskores/rendering/Wireframer.h
Hunk #6 FAILED at 525.
1 out of 6 hunks FAILED -- saving rejects to file viskores/rendering/Wireframer.h.rej
Error: Process completed with exit code 1.

boo I will take a look!

@nicolemarsaglia

Copy link
Copy Markdown
Contributor Author

@cyrus fixed patch issue. now it's failing on the test i added a new baseline image for. I'll investigate more tomorrow

@nicolemarsaglia

Copy link
Copy Markdown
Contributor Author

@cyrush I think the ci is still building v1.0.0
Screenshot 2026-05-27 at 10 46 20 AM

@cyrush

cyrush commented May 29, 2026

Copy link
Copy Markdown
Member

@nicolemarsaglia

Containers are now all using viskores 1.1.1 with our patches.
Good news is that windows is healed.

But we have an issue with the domain_id and rank_id filters:

Screenshot 2026-05-29 at 9 18 58 AM

Can you take a look at this using azemu?

@cyrush

cyrush commented May 30, 2026

Copy link
Copy Markdown
Member

@nicolemarsaglia thanks for resolving that last puzzle!

@cyrush cyrush merged commit c7ff170 into develop May 30, 2026
19 checks passed
@cyrush cyrush deleted the task/2026_04_09_update_viskores_1.1.0 branch May 30, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants