Multi dark #20

[aditianshu]

Making the toggle into a select menu to enable choices between various dark themes.

[plxity]

@aditianshu Please provide a demo link.

[aditianshu]

Here's the demo.

https://codepen.io/aditianshu/pen/OJVavKd

[yellowwoods12]

@aditianshu Kindly set the default theme to dark.

[yellowwoods12]

Also there's more that can be done for this specific enhancement that will be done in separate issues to encourage participation. After this slight change, we can merge this one for now.
@plxity what do you think?

[aditianshu]

@yellowwoods12 made the required changes.

[AdityaSrivast]

@aditianshu Also make appropriate changes in the docs

[plxity]

Also there's more that can be done for this specific enhancement that will be done in separate issues to encourage participation. After this slight change, we can merge this one for now.
@plxity what do you think?

I think we need some more changes on this before merging. Let's provide a way to add as many themes as user wants. The idea is to not keep some fixed number of themes and provide the user with an option to add as many required.

@aditianshu I would suggest counting the number of "data-theme" present in CSS file and append their names in the dropdown. SO user can add as many themes as required. and please specify the issue number in this PR.

@yellowwoods12 We can't merge this in master branch let's make a different branch for adding this multiple options feature. What do you suggest?

[yellowwoods12]

I think we need some more changes on this before merging. Let's provide a way to add as many themes as user wants. The idea is to not keep some fixed number of themes and provide the user with an option to add as many required.

@plxity actually I was thinking of providing 4-5 general themes and then a custom theme wherein the RGB value of the background and the font can be entered or maybe selected from a color chart and the theme will be rendered.
But this should be done in a separate PR as it is a lot of changes for a single PR.
Yes we should merge it in a separate branch for now.

[aditianshu]

@yellowwoods12 have made the changes mentioned by @AdityaSrivast
Do I have to do anything further?

[yellowwoods12]

Looks fine to me. @plxity what do you think?

[yellowwoods12]

@plxity Have a look.

[plxity]

@yellowwoods12 A lot of development is still required on this. But this can be merged for further changes in a different branch. @aditianshu can you raise this PR for added-multi-branch-option branch?

[aditianshu]

Raised the PR on a different branch.