fix: correct array concatenation and randomness usage in UintNote #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses and corrects Noir compatibility, code safety, and style issues in
uint_note.nr
.Improvements include safer randomness usage, robust array concatenation, updated constant declarations, and clarified assertions. These changes ensure the contract logic remains secure, maintainable, and compatible with current Noir standards.
Problem
Solution
random()
usage.const
for clarity and compatibility.How to Test
noir test -b uint-note
Additional Context
These changes align the code with best practices for Noir development and should reduce future technical debt.
If you have questions or suggestions, please let's discuss here