feat: Soft-delete mined txs from tx pool #17131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
force-pushed
the
palla/soft-delete-mined-txs-from-pool
branch
from
6861461 to
e17887a
Compare
When deleting mined txs due to a reorg or eviction, we soft-delete them instead, and permanently delete them only when the original block number in which they were mined gets finalized. This allows us to keep txs from pruned epochs available in the pool, which we need for identifying data withholding slash conditions in the epoch prune watcher. Otherwise, since we were potentially deleting mined txs from pruned epochs (eg if they became invalid as they were built on top of removed blocks), we would lose them and incorrectly think we were seeing a data withholding slash condition.
spalladino
force-pushed
the
palla/soft-delete-mined-txs-from-pool
branch
from
e17887a to
437b469
Compare
alexghr
approved these changes
Sep 19, 2025
|
|
||
| // This test needs longer slot window to ensure that the client has enough time to submit their txs, | ||
| // and have the nodes get recreated, prior to the reorg. | ||
| const AZTEC_SLOT_DURATION = process.env.AZTEC_SLOT_DURATION ? parseInt(process.env.AZTEC_SLOT_DURATION) : 32; |
There was a problem hiding this comment.
Shouldn't the default be.. 36?
There was a problem hiding this comment.
Well, this works because the ethereum slot duration is 4 in this test
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting mined txs due to a reorg or eviction, we soft-delete them instead, and permanently delete them only when the original block number in which they were mined gets finalized.
This allows us to keep txs from pruned epochs available in the pool, which we need for identifying data withholding slash conditions in the epoch prune watcher. Otherwise, since we were potentially deleting mined txs from pruned epochs (eg if they became invalid as they were built on top of removed blocks), we would lose them and incorrectly think we were seeing a data withholding slash condition.
This PR also includes a fix to the
sequencer-publisher. Since the publisher is no longer long-lived, themyLastSignalscache was being lost. It's now expanded to track every action, and kept alive by the publisher factory.