[metrics] File type detection for binary files and custom patterns #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduenas
requested changes
Mar 12, 2025
jjmerchante
force-pushed
the
file-extensions
branch
from
e8d4384 to
a25b5a4
Compare
|
I included one example of each of the possible patterns |
sduenas
requested changes
Mar 13, 2025
tests/unit/test_metrics.py
Outdated
Comment on lines
135
to
138
| file_metrics = analyzer.get_file_type_metrics() | ||
| self.assertEqual(file_metrics.get("code", 0), 53) | ||
| self.assertEqual(file_metrics.get("binary", 0), 4) | ||
| self.assertEqual(file_metrics.get("other", 0), 22) |
There was a problem hiding this comment.
We need a test that checks all of them are zero.
This commit adds binary file type detection, identifying some popular binary executables and compressed binary files. Signed-off-by: Jose Javier Merchante <[email protected]>
This commit allows to define custom file type patterns for code and binary files. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
file-extensions
branch
from
a25b5a4 to
f490107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves file type detection by adding support for identifying common binary executables and compressed files.
Additionally, it allows to define custom file type patterns for both code and binary files.