[metrics] Add custom thresholds for metrics calculations #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjmerchante
force-pushed
the
metrics-thresholds
branch
from
c56adac to
5a28ec9
Compare
sduenas
requested changes
Mar 18, 2025
grimoirelab_metrics/cli.py
Outdated
Comment on lines
83
to
93
| @click.option("--pony-threshold", type=float, show_default=True, help="Pony factor threshold, between 0 and 1", default=0.5) | ||
| @click.option( | ||
| "--elephant-threshold", type=float, show_default=True, help="Elephant factor threshold, between 0 and 1", default=0.5 | ||
| ) | ||
| @click.option( | ||
| "--dev-categories-thresholds", | ||
| type=str, | ||
| show_default=True, | ||
| help="Developer categories thresholds, between 0 and 1", | ||
| default="0.8,0.95", | ||
| ) |
There was a problem hiding this comment.
Click has options to check that the values are between 0 and 1. I think it's something the script has to check before doing anything else.
Comment on lines
87
to
93
| @click.option( | ||
| "--dev-categories-thresholds", | ||
| type=str, | ||
| show_default=True, | ||
| help="Developer categories thresholds, between 0 and 1", | ||
| default="0.8,0.95", | ||
| ) |
There was a problem hiding this comment.
I think it's better to pass to numbers instead of a string that we have to parse later. If it's not possible to do it, click should parse it and convert it to numbers.
grimoirelab_metrics/cli.py
Outdated
| binary_file_pattern: str | None = None, | ||
| pony_threshold: float = 0.5, | ||
| elephant_threshold: float = 0.5, | ||
| dev_categories_thresholds: str = "0.8,0.95", |
There was a problem hiding this comment.
This should be a tuple of numbers (maybe a named tuple) and not a string.
jjmerchante
force-pushed
the
metrics-thresholds
branch
2 times, most recently
from
b93827a to
5a6f92e
Compare
This commit allows to define custom thresholds for metrics like Pony factor, Elephant factor and Developer onion analysis. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
metrics-thresholds
branch
from
5a6f92e to
ad08120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows defining custom thresholds for metrics like Pony factor, Elephant factor, and Developer onion analysis.
Wait for #15 to be merged to update the tests