Render rings with BJ Jonsson radial profiles#2578
Draft
levinli303 wants to merge 1 commit into
Draft
Conversation
Adds an opt-in radial-profile shading mode for planetary rings based on Bjorn Jonsson's Saturn ring profiles. When a RingSystem provides all of: - Texture (RGBA profile: back/forward/unlit/transparency) - ColorTexture (radial RGB color) - UnlitColor (tint applied to unlit-side brightness) the renderer switches to a phase-aware shading model that blends the backscatter and forward-scatter profiles on the lit side and uses the unlit-side profile (tinted by UnlitColor) on the dark side. Forward scatter is normalized so the G channel saturates at phase = 139 degrees, matching the capture geometry of BJ's data set. If any of the three keys is missing, the existing diffuse shading path is used unchanged.
levinli303
force-pushed
the
rings-new-profile
branch
from
June 12, 2026 06:43
aa150f1 to
db755c3
Compare
|
Contributor
|
Context: I asked levin to make this PR so we could see how their ring rendering implementation works. My current thought is that I would like to explore options for theory-based rendering of ring textures (for example, calculate backlighting from transparency), since this code hard-coded the Saturn rings' optical behaviour (the 139 degrees angle that the forward scattering texture is taken from), and also forward scattering and backlighting data are not available for the vast majority of ring systems and hence this code would probably be mostly useless beyond Saturn. This will probably be done on Discord. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.