Add proper temperatures for WC and WN stars#913
Draft
GurrenLagannTSS wants to merge 4 commits into
Draft
Conversation
Partially closes CelestiaProject#901, adding WNh is a bit of an hassle for me.
Collaborator
|
|
Sources: https://arxiv.org/pdf/1904.04687.pdf oh wait... maybe the WN5-WN6 temps should be lowered |
SevenSpheres
self-requested a review
February 7, 2021 17:14
375gnu
marked this pull request as draft
January 25, 2022 22:11
375gnu
force-pushed
the
master
branch
2 times, most recently
from
May 15, 2023 19:57
690ab56 to
2f8f3b0
Compare
Contributor
|
Hang on, what's the current issue with this thing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially implements and closes #901.
Also added temperatures for WNh stars as a workaround, avaiable when using luminosity classes II, I-a, I-b, and I-a0 for WN-class stars.