Skip to content

feat: don'use deprecated highlightBlock #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: don'use deprecated highlightBlock #4

wants to merge 2 commits into from

Conversation

zukka77
Copy link

@zukka77 zukka77 commented Aug 16, 2022

if highlightjs version >= 11 use highlightElement

@zukka77
feat: don'use deprecated highlightBlock
86286d8 
if highlightjs version >= 11 use highlightElement
@zukka77 zukka77 mentioned this pull request Aug 16, 2022
Open
@AdamPerkins
Copy link

AdamPerkins commented Aug 17, 2022 •
edited
Loading

You should compare like this:

if (Number(hljs__default["default"].versionString.slice(0, 2)) >= 11)

@zukka77
Copy link
Author

zukka77 commented Aug 17, 2022

@AdamPerkins I've committed your suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zukka77 @AdamPerkins