Open
Conversation
…g what it is and from what mod
HerrChaos
reviewed
Apr 15, 2026
HerrChaos
reviewed
Apr 15, 2026
lowercasebtw
changed the title
CelDaemon
reviewed
Apr 17, 2026
| InvalidateRenderStateCallback.EVENT.invoker().onInvalidate(); | ||
| } | ||
|
|
||
| @Inject(method = "lambda$addSkyPass$0", at = @At("HEAD"), cancellable = true) |
There was a problem hiding this comment.
Injecting into lambdas is rather brittle (especially on unobf), could we instead compose the lambda or wrap the pass.executes?
Author
There was a problem hiding this comment.
If you wrap the pass.executes itll call the code before it should I think and its working fine currently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be my first contribution to Fabric API. Had to rework some events from my original to work w/ fabric-api's ecosystem and how it handles events.
Events for each portion of the sky rendering, with corresponding important data accessible during those phases. Allowing cancelling of rendering such as the stars/sun/moon.
Also adds a custom element even in which although unused by FAPI, is intended for mod developers to invoke when adding custom elements to the sky when rendering allowing other mods to intercept them and do as please.
Progress:
Everything is implemented, only needs testing & javadoc work now.
Question:
Should the status of if the pre-event was cancelled be passed along to the post-event? Should the post event even be called if the pre-event was cancelled?