Skip to content

Conversation

XZWY
Copy link

@XZWY XZWY commented Jul 23, 2023

fix plot_individual_spectrum for music doa estimation

Thanks for sending a pull request (PR), we really appreciate that! Before hitting the submit button, we'd be really glad if you could make sure all the following points have been cleared.

Please also refer to the doc on contributing for more details. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.

  • Are there docstrings ? Do they follow the numpydoc style ?
  • Have you run the tests by doing nosetests or py.test at the root of the repo ?
  • Have you checked that the doc builds properly and that any new file has been added to the repo ? How to do that is covered in the documentation.
  • Is there a unit test for the proposed code modification ? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Last but not least, did you document the proposed change in the CHANGELOG file ? It should go under "Unreleased".

Happy PR 😃

fix plot_individual_spectrum for music doa estimation
@XZWY
Copy link
Author

XZWY commented Jul 23, 2023

line 150 in music.py, self.Pssl[k, 0 : len(azimuth)] should be self.Pssl[0 : len(azimuth), k], the index got reverted by the function _compute_spatial_spectrumvec

@fakufaku fakufaku self-assigned this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants