Merged
Conversation
CSS should probably be extracted to mltshp-patterns, as long as we can segment it into a separate admin CSS bundle for admin-specific components. Inlined scripts here are also admin-specific, so could be placed in an admin.js file, if there are things that can be shared with other admin views. Presently, there isn't a need.
Member
Good call — Can you make a ticket on the patterns repo? I can extract that stuff out later, the next time I get a chance to work on the pattern library, and make it a separate file. In the meantime, a followup action here might be to pull all the inline CSS into an admin.css file, to make the changeover in the future easier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS should probably be extracted to mltshp-patterns, as long as we can segment it into a separate admin CSS bundle for admin-specific components.
Inlined scripts here are also admin-specific, so could be placed in an admin.js file, if there are things that can be shared with other admin views. Presently, there isn't a need.