Merged
Conversation
georgewrmarshall
previously approved these changes
Mar 12, 2025
Comment on lines
+44
to
+45
| ]} | ||
| /> |
Contributor
There was a problem hiding this comment.
non-blocking: Consider adding a prop to allow access to this child element.
Suggested change
| ]} | |
| /> | |
| ]} | |
| {...innerBadgeProps} | |
| /> |
…/BadgeStatus.tsx Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
…/README.md Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
…/BadgeStatus.tsx Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
…gn-system into dsrn/badge-status
georgewrmarshall
previously approved these changes
Mar 20, 2025
Contributor
georgewrmarshall
left a comment
georgewrmarshall
left a comment
There was a problem hiding this comment.
LGTM! Left a couple non-blocking comments
|
|
||
| export const TWCLASSMAP_BADGESTATUS_SIZE: Record<BadgeStatusSize, string> = { | ||
| [BadgeStatusSize.Md]: 'h-2 w-2', // 8px width and height | ||
| [BadgeStatusSize.Lg]: 'h-2.5 w-2.5', // 10px width and height |
Comment on lines
+48
to
+51
| size: BadgeStatusSize.Md, | ||
| status: BadgeStatusStatus.Active, | ||
| hasBorder: true, | ||
| twClassName: '', |
Contributor
There was a problem hiding this comment.
This is nice to read! Nice work
Comment on lines
+6
to
+12
| export enum BadgeStatusStatus { | ||
| Active = 'active', | ||
| PartiallyActive = 'partiallyactive', | ||
| Inactive = 'inactive', | ||
| New = 'new', | ||
| Attention = 'attention', | ||
| } |
Contributor
There was a problem hiding this comment.
nit: consider adding comments here to explain what these mean in detail. It's somewhat of a niche component.
georgewrmarshall
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
BadgeStatuscomponent to the@metamask/design-system-react-nativepackageRelated issues
Fixes: #397
Manual testing steps
yarn storybook:iosfrom rootScreenshots/Recordings
Before
After
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-03-10.at.20.28.35.mp4
Pre-merge author checklist
Pre-merge reviewer checklist