detect-bytetest-02: fix alert count#3042
Closed
inashivb wants to merge 1 commit into
Closed
Conversation
There's just one packet in the pcap that matches the rules 4 and 5, there's no need for 2 alerts. However, with the way packet-stream rules are assessed by Suricata, the rules are inspected twice by packet and stream payload inspection engines thus creating 2 alerts.
Collaborator
|
There is not yet a suricata PR for this, right ? |
catenacyber
added
requires suricata fix
Member
Author
Indeed. In fact, it's looking like we may need to update some other tests to have the same behavior because it's hard to change how Suricata operates. |
Member
Author
|
Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's just one packet in the pcap that matches the rules 4 and 5, there's no need for 2 alerts. However, with the way packet-stream rules are assessed by Suricata, the rules are inspected twice by packet and stream payload inspection engines thus creating 2 alerts.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/8266