src/reputation: remove unused code

[spinaev]

Remove useless while() and simplify skiping empty lines/comments

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

• I have read the contributing guide lines at
  https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html

Our Contribution agreements:

• I have signed the Open Information Security Foundation contribution agreement at
  https://suricata.io/about/contribution-agreement/ (note: this is only required once)

Changes (if applicable):

• I have updated the User Guide (in doc/userguide/) to reflect the changes made
• I have updated the JSON schema (in etc/schema.json) to reflect all logging changes
  (including schema descriptions)
• I have created a ticket at
  https://redmine.openinfosecfoundation.org/projects/suricata/issues

Link to ticket: https://redmine.openinfosecfoundation.org/issues/8500

Removed useless while() and simplified skiping empty lines/comments

Provide values to any of the below to override the defaults.

• To use a Suricata-Verify or Suricata-Update pull request,
  link to the pull request in the respective _BRANCH variable.
• Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=OISF/suricata-verify#3059
SU_REPO=
SU_BRANCH=

[spinaev]

@catenacyber here it is

[catenacyber]

Could we simply just remove this line ?

[spinaev]

yes, we can. i just dont like code duplication...

[catenacyber]

Ok : can we split the commit in 2 commits ? I think it is better to have the smallest commit possible to fix the underflow bug, then we can have another commit to deduplicate code

[spinaev]

done, i think

[catenacyber]

Could we have a Suricata-verify test with reputation file 0xC 0xA ?

Did you try to fuzz this code ?

[github-actions]

NOTE: This PR may contain new authors.

[spinaev]

@catenacyber if i learn how to make "suricata verify tests" - yes, i can add it.

no, i don't try to fuzz it

[catenacyber]

See https://github.com/OISF/suricata-verify/blob/master/README.md

[github-actions]

NOTE: This PR may contain new authors.

[catenacyber]

CI for C code formatting is red : https://github.com/OISF/suricata/actions/runs/25101263021/job/73551519009?pr=15256

You can fix it with ./scripts/clang-format.sh

[spinaev]

@catenacyber now i can create a test, but it will not fail, just cause buffer underrun. shall i add such test?

[catenacyber]

It should fail when Suricata is built with ASAN, so yes please add such a test

[spinaev]

It should fail when Suricata is built with ASAN, so yes please add such a test

done

[catenacyber]

Thanks. Could you rebase to latest main and to a new PR to get green CI ?
See https://docs.suricata.io/en/latest/devguide/contributing/code-submission-process.html#pull-requests

[spinaev]

Thanks. Could you rebase to latest main and to a new PR to get green CI ? See https://docs.suricata.io/en/latest/devguide/contributing/code-submission-process.html#pull-requests

#15285