Fw updates/v18#15300
Closed
victorjulien wants to merge 23 commits intoOISF:mainfrom
Closed
Conversation
- tls.cert_chain_len - datarep - dataset - dns.opcode Part of Ticket OISF#8387
The firewall enabling flag for tcp.flags was being overwritten by another line of code. Related to Ticket OISF#8387
Clean up host mode tracking, which is used by reject to control how rejects are sent. Before this patch there were 2 modes: sniffer only and router. This patch introduces a bridge mode that is automatically set by the bridge modes. In bridge mode the `Packet::livedev` is used. Ticket: OISF#8390.
So a value of 0 means no device.
Most code uses an opague type for LiveDevice, so add an id getter.
In prep for storing both directions for IPS.
Update ctx caching to take direction into account.
Use an enum for the firewall related flow control, to improve readability of the firewall inspection logic.
If a ruleset would use `dns:request_complete` but not have a rule for `dns:request_started`, the `request_started` hook default policy would not get invoked. Add a check to make sure it is invoked. Ticket: OISF#8495.
For non-UDP (so TCP), don't allow `accept:packet` or `drop:packet` as this makes the evaluation of other rule hooks unpredictable. Ticket: OISF#8497.
When there are no rules after prefilter the default policy needs to be invoked.
Fixes: 232276a ("detect: ethernet/arp matching")
For firewall rules, allow multiple actions to be specified in a list
accept:flow,pass:flow,alert
accept:flow,alert
accept:flow,pass:flow
It is mandatory to make the first action the primary firewall policy
action: accept, drop, reject.
Ticket: OISF#8480.
For improved readability.
Previously a `accept:flow` action would act as both a firewall "accept" and a threat detection "pass" for the rest of the flow. This patch changes that. The `accept:flow` action now only accepts the rest of the packets for the firewall ruleset, but does still continue threat detection rule evaluation. Ticket: OISF#8444.
Closed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15300 +/- ##
==========================================
- Coverage 82.65% 82.63% -0.02%
==========================================
Files 993 993
Lines 270997 271136 +139
==========================================
+ Hits 223985 224057 +72
- Misses 47012 47079 +67
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
WARNING:
Pipeline = 31147 |
Closed
Member
Author
|
CI issues addressed in #15306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SV_BRANCH=OISF/suricata-verify#3044
Replaces #15253:
Tickets: