unittests: convert util-spm tests to FAIL/PASS API#15371
Closed
0x-0ddc0de wants to merge 1 commit into
Closed
Conversation
inashivb
reviewed
May 12, 2026
inashivb
left a comment
inashivb
left a comment
Member
There was a problem hiding this comment.
Thank you for your work! This is looking good. One minor comment.
| printf("Error1 searching for %s in text %s\n", needle[i], text[i][j]); | ||
| return 0; | ||
| } | ||
| FAIL_IF(found == 0); |
Member
There was a problem hiding this comment.
nit: all these FAIL_IF(blah == 0) could be replaced with FAIL_IF_NOT(blah)
|
NOTE: This PR may contain new authors. |
Contributor
|
Replaced by #15382 |
This was referenced May 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to address comments on
Changes since PR v3:
SpmTestSearchto use non-branching FAIL_IFSpmSearchTest02Issue: 6334