refactor: replace GetTrips() full-table load with targeted DB query#850
Merged
Ahmedhossamdev merged 2 commits intomainfrom Apr 11, 2026
Merged
refactor: replace GetTrips() full-table load with targeted DB query#850Ahmedhossamdev merged 2 commits intomainfrom
Ahmedhossamdev merged 2 commits intomainfrom
Conversation
Performance Smoke Test ResultsStatus: PASSED
Smoke test config: 5 VUs x 30s. Thresholds: p(95) < 300ms, error rate < 1%. Full results uploaded as workflow artifact: k6-smoke-summary. |
fletcherw
approved these changes
Apr 11, 2026
gtfsdb/stops_rtree.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer rows.Close() |
Collaborator
There was a problem hiding this comment.
where'd you see the error lint for this? was it in presubmits or somewhere else?
Member
Author
There was a problem hiding this comment.
When I run make lint
Ahmedhossamdev
force-pushed
the
refactor/migrate-get-trips-to-db
branch
from
238bd7c to
3ddad09
Compare
Performance Smoke Test ResultsStatus: PASSED
Smoke test config: 5 VUs x 30s. Thresholds: p(95) < 300ms, error rate < 1%. Full results uploaded as workflow artifact: k6-smoke-summary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #826
Part of: #820
Summary
GetTrips()(which loaded all trips fromgtfsData.Trips) and replaces it withGetTrips(ctx, limit)backed by a newListTripsWithLimitSQL queryListTripsWithLimittoquery.sql— usesLIMIT ?to avoid full-table scans, especially important for large merged feedsmustGetTrips(t, api)helper (limit 100) and maps flatgtfsdb.Tripfields (RouteID,ServiceID,TripHeadsign, etc.) replacing the old nestedgtfs.ScheduledTripfields (Route.Id,Service.Id,Headsign, etc.)errchecklint issue instops_rtree.go