Skip to content

Disallow low-resolution calibration#2438

Merged
mcm001 merged 11 commits intoPhotonVision:2027from
cswilson252:rebasedLowResolutionCal
May 3, 2026
Merged

Disallow low-resolution calibration#2438
mcm001 merged 11 commits intoPhotonVision:2027from
cswilson252:rebasedLowResolutionCal

Conversation

@cswilson252
Copy link
Copy Markdown
Contributor

@cswilson252 cswilson252 commented Apr 22, 2026

Description

Filter calibration resolution options plus preview table to only resolutions with at least 640*480 pixels^2 of area. We can tune this later if it's too aggressive.

If lower resolutions are calibrated, users will no longer be able to see them on the table. This is fine. They shouldn't have been using them anyways

Closes #1719
Successor to #2390

Meta

Merge checklist:

Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes
The description documents the what and why, including events that led to this PR
If this PR changes behavior or adds a feature, user documentation is updated

@cswilson252 cswilson252 requested review from a team as code owners April 22, 2026 03:36
@github-actions github-actions Bot added documentation Anything relating to https://docs.photonvision.org frontend Having to do with PhotonClient and its related items photonlib Things related to the PhotonVision library backend Things relating to photon-core and photon-server labels Apr 22, 2026
@cswilson252 cswilson252 changed the base branch from main to 2027 April 22, 2026 03:36
@cswilson252
Copy link
Copy Markdown
Contributor Author

oops

@spacey-sooty spacey-sooty removed documentation Anything relating to https://docs.photonvision.org photonlib Things related to the PhotonVision library backend Things relating to photon-core and photon-server labels Apr 22, 2026
Comment thread photon-client/src/components/cameras/CameraCalibrationCard.vue Outdated
Comment thread photon-client/src/components/cameras/CameraCalibrationCard.vue Outdated
@cswilson252 cswilson252 requested a review from mcm001 April 23, 2026 04:31
Comment thread photon-client/src/components/cameras/CameraCalibrationCard.vue Outdated
@cswilson252 cswilson252 requested a review from mcm001 April 26, 2026 16:53
@github-actions github-actions Bot added the documentation Anything relating to https://docs.photonvision.org label Apr 28, 2026
@cswilson252
Copy link
Copy Markdown
Contributor Author

cc @samfreund

Copy link
Copy Markdown
Member

@samfreund samfreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good.

The default value for the selector is a resolution that shouldn't be allowed. See below.

Image

Comment thread docs/source/docs/calibration/calibration.md Outdated
@samfreund samfreund force-pushed the rebasedLowResolutionCal branch from 66581a5 to 81900e7 Compare May 1, 2026 22:27
Comment thread photon-client/src/components/cameras/CameraCalibrationCard.vue Outdated
@cswilson252 cswilson252 requested a review from samfreund May 2, 2026 00:41
Comment thread photon-client/src/components/cameras/CameraCalibrationCard.vue Outdated
@samfreund
Copy link
Copy Markdown
Member

We still want 640x480 yes? That's pursuant to my above change

@samfreund samfreund force-pushed the 2027 branch 2 times, most recently from 5d13758 to 803bdb2 Compare May 2, 2026 19:14
@samfreund samfreund force-pushed the rebasedLowResolutionCal branch from 77daf27 to 6fb5313 Compare May 3, 2026 02:37
@samfreund samfreund self-requested a review May 3, 2026 02:43
@mcm001
Copy link
Copy Markdown
Contributor

mcm001 commented May 3, 2026

PR description looks stale?

@mcm001 mcm001 enabled auto-merge (squash) May 3, 2026 17:11
@samfreund samfreund force-pushed the rebasedLowResolutionCal branch 3 times, most recently from a2f187c to 7b0d2f9 Compare May 3, 2026 17:27
@samfreund samfreund force-pushed the rebasedLowResolutionCal branch from 7b0d2f9 to b1ff3ab Compare May 3, 2026 17:31
@cswilson252
Copy link
Copy Markdown
Contributor Author

ty for fixing up my pr y'all!! :)

@mcm001 mcm001 merged commit dbf7102 into PhotonVision:2027 May 3, 2026
53 of 54 checks passed
samfreund pushed a commit that referenced this pull request May 3, 2026
@cswilson252 cswilson252 deleted the rebasedLowResolutionCal branch May 3, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Anything relating to https://docs.photonvision.org frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disallow low-resolution calibration

4 participants