Disallow low-resolution calibration#2438
Merged
mcm001 merged 11 commits intoPhotonVision:2027from May 3, 2026
Merged
Conversation
Contributor
Author
|
oops |
mcm001
reviewed
Apr 22, 2026
mcm001
reviewed
Apr 23, 2026
Contributor
Author
|
cc @samfreund |
samfreund
requested changes
Apr 28, 2026
66581a5 to
81900e7
Compare
samfreund
reviewed
May 1, 2026
samfreund
reviewed
May 2, 2026
Member
|
We still want 640x480 yes? That's pursuant to my above change |
5d13758 to
803bdb2
Compare
77daf27 to
6fb5313
Compare
Contributor
|
PR description looks stale? |
mcm001
approved these changes
May 3, 2026
samfreund
approved these changes
May 3, 2026
a2f187c to
7b0d2f9
Compare
Co-authored-by: Sam Freund <samf.236@proton.me>
7b0d2f9 to
b1ff3ab
Compare
Contributor
Author
|
ty for fixing up my pr y'all!! :) |
samfreund
pushed a commit
that referenced
this pull request
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Filter calibration resolution options plus preview table to only resolutions with at least 640*480 pixels^2 of area. We can tune this later if it's too aggressive.
If lower resolutions are calibrated, users will no longer be able to see them on the table. This is fine. They shouldn't have been using them anyways
Closes #1719
Successor to #2390
Meta
Merge checklist: