Schema-qualify comparison functions and operators in sync_enum_values#131
Open
dtikhonov wants to merge 1 commit intoPogchamp-company:developfrom
Open
Schema-qualify comparison functions and operators in sync_enum_values#131dtikhonov wants to merge 1 commit intoPogchamp-company:developfrom
dtikhonov wants to merge 1 commit intoPogchamp-company:developfrom
Conversation
The library creates temporary comparison functions (new_old_equals, new_old_not_equals) and operators (=, !=) during enum value sync. Previously these were created with unqualified names, defaulting to the public schema. When the migration user lacks CREATE privileges on the public schema, this caused permission denied errors. Now the functions and operators are created in the enum's own schema (e.g. "myschema".new_old_equals), which only requires privileges on the schema where the enum already lives. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The library creates temporary comparison functions (new_old_equals, new_old_not_equals) and operators (=, !=) during enum value sync. Previously these were created with unqualified names, defaulting to the public schema. When the migration user lacks CREATE privileges on the public schema, this caused permission denied errors.
Now the functions and operators are created in the enum's own schema (e.g. "myschema".new_old_equals), which only requires privileges on the schema where the enum already lives.
Checklist
This pull request is:
must include a complete example of the issue. one line code fixes without an
issue and demonstration will not be accepted.
Fixes: #<issue number>in the commit messageinclude a complete example of how the feature would look.
Fixes: #<issue number>in the commit message