Skip to content

Conversation

hackermondev
Copy link
Contributor

@hackermondev hackermondev commented Jul 29, 2025

New Features

Both changes are Postgres only.

Copy link
Member

@Expurple Expurple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you want to backport this to 0.32.x branch too? (the one used in the current SeaORM 1.1.x)

@Expurple Expurple requested a review from tyt2y3 July 30, 2025 07:11
@hackermondev
Copy link
Contributor Author

Thanks! Do you want to backport this to 0.32.x branch too? (the one used in the current SeaORM 1.1.x)

Yeah, would I have to create a new PR?

@hackermondev
Copy link
Contributor Author

I'm going to add to the PR to support Postgres index operator classes. Should close #907

@hackermondev hackermondev changed the title feat(index): add support for CONCURRENTLY modifying indexes feat(indexes): Support for CONCURRENTLY modifying indexes and indexing column operator class Jul 30, 2025
@Expurple
Copy link
Member

Expurple commented Jul 31, 2025

Yeah, a separate PR against 0.32.x. You should be able to rebase/cherry-pick your commit with little-to-no conflicts in this area.

Move operator classes into separate PRs, please

@tyt2y3
Copy link
Member

tyt2y3 commented Aug 3, 2025

I can do the backporting to 0.32. though it'd be great to break down the PR into two, one for each feature.

@hackermondev
Copy link
Contributor Author

Sorry for the long wait. I've created 2 separate PRs.
#963 #964

There might be some merge conflicts with the tests (since the test names are sequentially ordered), but those should be easily fixable.

@Expurple
Copy link
Member

Thank you. Let's close this one then

@Expurple Expurple closed this Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for specifying operator class in expression indexes (e.g. gist_trgm_ops)
3 participants