-
Notifications
You must be signed in to change notification settings - Fork 298
RN 43793 #5306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Wondering if we should add something to EnableSwarming.html page that mentions the higher version requirement for DVE/VF?
Maybe somthing to clarify that 10.5.1 is the bare minimum for basic elements but that other features might require higher version. To see upcoming feature list? |
I wondered about that too, but I'm worried about adding the same information in too many places, since that's not very update-friendly. So as that page only seems to focus on what you do to activate swarming instead of what you have to do to swarm specific items (e.g. bookings), I'd be inclined to leave it as it is. |
Good idea! I've updated the version requirements on that page. |
Agreed, even though it should probably never need updating. We could also make a table somewhere with a list of what functionality requires which version and then refer to the table for specfics while keeping the minimum requirement 10.5.1/10.6 everywhere |
I do want to avoid the situation where somebody reads 10.5.1 then upgrades and then realized they need a higher version as they have certain functionality they also want to swarm. |
Maybe somthing like this: Current featuresFunctionality | version | NotesBasic elements | 10.5.1/10.6 | Upcoming features
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@RobbeDGH, could you check if this pull request is OK to add RN 43793 to the documentation?