Skip to content

feat(xsAI): add xsAI voice provider#98

Merged
omeraplak merged 4 commits intoVoltAgent:mainfrom
yusuf-eren:main
May 7, 2025
Merged

feat(xsAI): add xsAI voice provider#98
omeraplak merged 4 commits intoVoltAgent:mainfrom
yusuf-eren:main

Conversation

@yusuf-eren
Copy link
Copy Markdown
Contributor

@yusuf-eren yusuf-eren commented May 6, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

xsAI is not supported as a Voice Provider.

What is the new behavior?

Adds support for xsAI as a Voice Provider.

Notes for reviewers

Issue: #90

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2025

🦋 Changeset detected

Latest commit: d3d1f92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@voltagent/voice Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@omeraplak
Copy link
Copy Markdown
Member

Hey @yusuf-eren ,
Wow, this looks amazing! Would you mind adding it to the docs as well?
Here’s the link: https://voltagent.dev/docs/agents/voice/ 🙏

Comment thread packages/voice/src/providers/xsai/types.ts Outdated
@yusuf-eren
Copy link
Copy Markdown
Contributor Author

Hi @omeraplak , I updated the docs and resolved the recommended change by @kwaa

/* ------------------------------------------------------------------ */
/* xsAI provider */
/* ------------------------------------------------------------------ */
export class XsaiVoiceProvider extends BaseVoiceProvider {
Copy link
Copy Markdown
Contributor

@kwaa kwaa May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voltagent/xsai uses XsAIProvider, and it's best to be consistent.

That said, this naming is not easy to type...

I suggest changing here and @voltagent/xsai to XSAIVoiceProvider and XSAIProvider.

@omeraplak what do you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense. I hadn’t noticed the typing difficulty either since IDE autocompletion usually handles it. Let’s go with XsAIVoiceProvider in this PR for now, and we can create a separate issue to properly discuss renaming both the package and class for consistency and ease of use. Thanks for catching that!

@yusuf-eren
Copy link
Copy Markdown
Contributor Author

@omeraplak how can we merge the PR? It says "1 workflow awaiting approval" .

@omeraplak omeraplak merged commit c3db06d into VoltAgent:main May 7, 2025
4 checks passed
@omeraplak
Copy link
Copy Markdown
Member

@omeraplak how can we merge the PR? It says "1 workflow awaiting approval" .

Thank you for the contribution! Merged 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants