feat(xsAI): add xsAI voice provider#98
Conversation
🦋 Changeset detectedLatest commit: d3d1f92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @yusuf-eren , |
|
Hi @omeraplak , I updated the docs and resolved the recommended change by @kwaa |
| /* ------------------------------------------------------------------ */ | ||
| /* xsAI provider */ | ||
| /* ------------------------------------------------------------------ */ | ||
| export class XsaiVoiceProvider extends BaseVoiceProvider { |
There was a problem hiding this comment.
@voltagent/xsai uses XsAIProvider, and it's best to be consistent.
That said, this naming is not easy to type...
I suggest changing here and @voltagent/xsai to XSAIVoiceProvider and XSAIProvider.
@omeraplak what do you think?
There was a problem hiding this comment.
Yep, makes sense. I hadn’t noticed the typing difficulty either since IDE autocompletion usually handles it. Let’s go with XsAIVoiceProvider in this PR for now, and we can create a separate issue to properly discuss renaming both the package and class for consistency and ease of use. Thanks for catching that!
|
@omeraplak how can we merge the PR? It says "1 workflow awaiting approval" . |
Thank you for the contribution! Merged 🚀 |
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
xsAI is not supported as a Voice Provider.
What is the new behavior?
Adds support for xsAI as a Voice Provider.
Notes for reviewers
Issue: #90