Fixed Duplicate and Input nodes creating objects only once in a for-loop#109
Open
tomoaki-e33 wants to merge 1 commit intoaachman98:masterfrom
Open
Fixed Duplicate and Input nodes creating objects only once in a for-loop#109tomoaki-e33 wants to merge 1 commit intoaachman98:masterfrom
tomoaki-e33 wants to merge 1 commit intoaachman98:masterfrom
Conversation
aachman98
requested changes
Mar 6, 2020
Owner
There was a problem hiding this comment.
I really like how you handled the object creation when the node is re-executed, but I think there might be an easier workaround.
Consider the following steps:
- Create an object: bpy.ops.mesh.primitive_something_add(something)
- Go to edit mode
- Use same function used in Step 1 to append geometry into same object without creating a separate mesh.
So instead of manually keeping record of all the objects generated, it would be better to create additional set of nodes that call bpy.ops.mesh, but in Edit Mode of the input object. The class "ScEditOperatorNode" would be the parent class for those nodes (rather than "ScInputNode").
We can think of something similar for "Duplicate Object" node.
Owner
|
We'll have to add a prefix to the current input nodes, like "Create Cube". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example node tree:



Result in v3.1.4:
Result after this PR: