Fix lack of activity log entries, reorganize sensor classes.#753
Open
mdrobnak wants to merge 1 commit into
Open
Fix lack of activity log entries, reorganize sensor classes.#753mdrobnak wants to merge 1 commit into
mdrobnak wants to merge 1 commit into
Conversation
fc645da to
f82421a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there. I have recently been testing both this and ESPresense, and noticed that with the latter, but room names would show up in the activity log as well as the history graph. With Bermuda, that wasn't happening. So that sent me down the rabbit hole of trying to figure out what was going wrong.
The device class that was set effectively blocked it from working, as well as the "state" attribute not being set. Once those two things were done, I noticed your comments mentioned a reorganization of the sensor classes, so I tried my best to logically lay them out for least amount of duplication.
While testing this, I also noticed the Area Switch Reason was more Area Switch Diagnostics - so I added the actual switch reason text as an attribute and gave the sensor that text, and moved the diagnostic text to Area Switch Diagnostic.
As a new user, I also hit into this "why is it going to unknown, that's frustrating" before discovering Area Last Seen, so I set that as a default if people were trying to use this in a lost device in house scenario.
I ran this through the pre-commit checks, so I think from a formatting standpoint this should be OK.
Please let me know if you'd like to see any changes here before accepting.
Thanks for your work so far on this project, it's great!
-Matt