Add Docker support for Mermaid benchmark tooling#18
Add Docker support for Mermaid benchmark tooling#18andrewginns wants to merge 2 commits intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Install Node.js and npm for mermaid-cli | ||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends nodejs npm \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Install mermaid CLI globally | ||
| RUN npm install -g @mermaid-js/mermaid-cli |
There was a problem hiding this comment.
The Docker image installs Node and @mermaid-js/mermaid-cli but never installs the system libraries that Puppeteer’s bundled Chromium requires. On Debian-bookworm bases, running mmdc without packages such as libnss3, libatk-bridge2.0-0, libgtk-3-0, libasound2, and fonts results in Error: Failed to launch the browser process before any diagrams are rendered. Because the entrypoint relies on mermaid-cli for the benchmark, the container will fail at runtime. Add the standard Chromium dependency packages during the apt-get install step so the CLI can start successfully.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Testing
Codex Task