Fix matrix row and column mixup #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m_matrix elements point to the rows, so the first index should be related to the height, and the second index to the width. It does end up working without this fix, because the matrix width is constrained to be 1 in both vectorMagnitudeSquared() and dot(), and the matrix elements are stored consecutively, in one array, so the memory accesses are exactly the same in both cases. So, this is mostly a cosmetic fix (ATM), but can help with understanding the code.
khernyo
force-pushed
the
fix-matrix-row-col-mixup
branch
from
e88027b to
f4c49e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m_matrix elements point to the rows, so the first index should be
related to the height, and the second index to the width.
It does end up working without this fix, because the matrix width is
constrained to be 1 in both vectorMagnitudeSquared() and dot(), and the
matrix elements are stored consecutively, in one array, so the memory
accesses are exactly the same in both cases. So, this is mostly a
cosmetic fix (ATM), but can help with understanding the code.