-
Notifications
You must be signed in to change notification settings - Fork 356
ADLS Multi-Datalake Support (fsspec) #2332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
hey @tbirch-cyber thanks for the PR. could you explain whats the reasoning behind this change? |
Hi @kevinjqliu thanks for taking the time to review! Sorry I should have put more in the PR message. Basically, it is very common to have a catalog split across multiple "storage accounts" (similar to an S3 bucket). Because of this, I need a way to provide a credential with an audience of
I think a similar approach could probably also be used with S3: https://github.com/fsspec/s3fs/blob/main/s3fs/core.py#L203 Please let me know if there’s anything else you’d like changed or if you think this approach isn't maintainable. Thanks! |
Merge with upstream
Merge with upstream
merge with upstream
Attempted to follow similar style to pyarrow implementation.
Simplifies/cleans up logic for #1146
Part of larger fsspec/pyarrow feature parity #2259
The netloc param may help with any custom logic needed for #2271