Skip to content

Conversation

gabeiglio
Copy link
Contributor

@gabeiglio gabeiglio commented Aug 30, 2025

Rationale for this change

Error handling differed with the Java implementation in the following:

  • 404 errors for tables or view can be NoSuchNamespaceError if the namespace does not exists (same as Java)
  • table commit will use the table error handler (instead of the commit error handler) if the commit will create a table (staged create)
  • Created ViewAlreadyExistsError for completeness even though we don't support creating views atm
  • Additionally this PR marks commit 503 errors as CommitStateUnkown as changed recently in Java

Are these changes tested?

Added two unit tests for testing the exception thrown between NoSuchNamespaceError and NoSuchTableError

Are there any user-facing changes?

No

@gabeiglio gabeiglio marked this pull request as ready for review August 30, 2025 21:27
@jayceslesar
Copy link
Contributor

more of a meta question but I wonder if we could auto generate some testing based off of the openapi spec upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants