fix: upsert with null values in join columns #2429
Open
+149
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdwint
force-pushed
the
fix/upsert-with-nulls
branch
from
76fc451 to
075a966
Compare
3 tasks
mdwint
force-pushed
the
fix/upsert-with-nulls
branch
2 times, most recently
from
6a7aa3f to
236b0c8
Compare
mdwint
force-pushed
the
fix/upsert-with-nulls
branch
from
236b0c8 to
479d11d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This fixes #2426. The upsert method now supports null values to be passed in the join columns.
Are these changes tested?
Yes, I added unit tests.
Are there any user-facing changes?
Yes, the upsert method is user-facing.