Add CreateTransaction test to CatalogTests #2466
Closed
+44
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree. I think having a complete catalog tests would be amazing. I have a PR open for sometime to test transactions. Just wanted to point it out so there is no duplicate work :) |
|
Great call! I'll go ahead and close this PR in favor of yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There's a bunch of CatalogTests in the Java implementation that we aren't testing in our regular Catalog tests. If this first one looks good, I'll start porting these over to help our test coverage.
Are these changes tested?
Tests should pass.
Are there any user-facing changes?
None