add ci-reporting, errorprone profile and record static code analysis #3
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,18 +38,21 @@ def call(Map params = [:]) { | |
| // minimum, LTS, current and next ea | ||
| def jdks = params.containsKey('jdks') ? params.jdks : params.containsKey('jdk') ? params.jdk : ['8','11','17'] | ||
| def jdkMin = jdks[0]; | ||
| def mavens = params.containsKey('maven') ? params.maven : ['3.6.x','3.8.x'] | ||
| // def failFast = params.containsKey('failFast') ? params.failFast : true | ||
| // Just temporarily | ||
| def failFast = false; | ||
| def siteJdks = params.containsKey('siteJdk') ? params.siteJdk : ['8'] | ||
| def siteMvn = params.containsKey('siteMvn') ? params.siteMvn : '3.8.x' | ||
| def siteOses = params.containsKey('siteOs') ? params.siteOs : ['linux'] | ||
| def tmpWs = params.containsKey('tmpWs') ? params.tmpWs : false | ||
|
|
||
| taskContext['failFast'] = failFast; | ||
| taskContext['tmpWs'] = tmpWs; | ||
| taskContext['archives'] = params.archives | ||
| taskContext['siteWithPackage'] = params.containsKey('siteWithPackage') ? params.siteWithPackage : false // workaround for MNG-7289 | ||
| taskContext['extraCmd'] = params.containsKey('extraCmd') ? params.extraCmd : '' | ||
| taskContext['ciReportingRunned'] = false | ||
|
|
||
| Map tasks = [failFast: failFast] | ||
| boolean first = true | ||
|
|
@@ -63,15 +66,16 @@ def call(Map params = [:]) { | |
| def mvn = jenkinsEnv.mavenForJdk(jdk) | ||
| doCreateTask( os, jdk, mvn, tasks, first, 'build', taskContext ) | ||
| } | ||
|
|
||
| // run with apache-release profile, consider it a dryRun with SNAPSHOTs | ||
| // doCreateTask( os, siteJdk, siteMvn, tasks, first, 'release', taskContext ) | ||
| } | ||
| for (String os in siteOses) { | ||
| for (def jdk in siteJdks) { | ||
| // doesn't work for multimodules yet | ||
| doCreateTask( os, jdk, siteMvn, tasks, first, 'site', taskContext ) | ||
| } | ||
| } | ||
| // run the parallel builds | ||
| parallel(tasks) | ||
|
|
||
|
|
@@ -119,18 +123,25 @@ def doCreateTask( os, jdk, maven, tasks, first, plan, taskContext ) | |
| echo "Skipping ${os}-jdk${jdk} as unsupported by Jenkins Environment" | ||
| return; | ||
| } | ||
| def recordReporting = false | ||
| def cmd = [ | ||
| 'mvn', '-V', | ||
| '-P+run-its', | ||
| '-Dfindbugs.failOnError=false', | ||
| '-e', | ||
| taskContext.extraCmd | ||
| ] | ||
| if (!first) { | ||
| cmd += '-Dfindbugs.skip=true' | ||
| // } else { // Requires authorization on SonarQube first | ||
| // cmd += 'sonar:sonar' | ||
| } | ||
| if (Integer.parseInt(jdk) >= 11 && !taskContext['ciReportingRunned']) { | ||
| cmd += "-Pci-reporting -Perrorprone" | ||
|
||
| taskContext['ciReportingRunned'] = true | ||
| recordReporting = true | ||
| } | ||
|
|
||
|
|
||
| if (plan == 'build') { | ||
| cmd += 'clean' | ||
|
|
@@ -213,6 +224,15 @@ def doCreateTask( os, jdk, maven, tasks, first, plan, taskContext ) | |
| } | ||
| } | ||
| } | ||
| if(recordReporting) { | ||
| recordIssues id: "${os}-jdk${jdk}", name: "Static Analysis", aggregatingResults: true, enabledForFailure: true, tools: [mavenConsole(), java(), checkStyle(), spotBugs(), pmdParser(), errorProne()] | ||
| jacoco inclusionPattern: '**/org/apache/maven/**/*.class', | ||
| exclusionPattern: '', | ||
| execPattern: '**/target/jacoco.exec', | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. good point to include IT test in coverage. |
||
| classPattern: '**/target/classes', | ||
| sourcePattern: '**/src/main/java' | ||
| recordReporting = false; | ||
| } | ||
| } catch (Throwable e) { | ||
| archiveDirs(taskContext.archives, stageDir) | ||
| // First step to keep the workspace clean and safe disk space | ||
|
|
@@ -241,6 +261,6 @@ def archiveDirs(archives, stageDir) { | |
| archives.each { archivePrefix, pathToContent -> | ||
| zip(zipFile: "${archivePrefix}-${stageDir}.zip", dir: pathToContent, archive: true) | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be at minimum 11, there are difference for javadoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhm not sure as javadoc can fail with jdk 1.8 and not 11. and the other way around :)
as we are 1.8 for most of the plugins etc maybe we need to ensure it works with this at least (as release folks might use 1.8 to build their release.