Skip to content

Commit ad7acec

Browse files
eschuthosadpandajoe
authored andcommitted
fix: Remove emotion-rgba from dependencies and codebase (#35124)
(cherry picked from commit 19ddcb7)
1 parent a423f8e commit ad7acec

File tree

4 files changed

+5
-12
lines changed

4 files changed

+5
-12
lines changed

superset-frontend/package-lock.json

Lines changed: 0 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

superset-frontend/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@
130130
"dom-to-image-more": "^3.6.0",
131131
"dom-to-pdf": "^0.3.2",
132132
"echarts": "^5.6.0",
133-
"emotion-rgba": "0.0.12",
134133
"eslint-plugin-i18n-strings": "file:eslint-rules/eslint-plugin-i18n-strings",
135134
"fast-glob": "^3.3.2",
136135
"fs-extra": "^11.2.0",

superset-frontend/src/dashboard/components/BuilderComponentPane/index.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* under the License.
1818
*/
1919
/* eslint-env browser */
20-
import { rgba } from 'emotion-rgba';
20+
import tinycolor from 'tinycolor2';
2121
import Tabs from '@superset-ui/core/components/Tabs';
2222
import { t, css, SupersetTheme, useTheme } from '@superset-ui/core';
2323
import { useSelector } from 'react-redux';
@@ -68,7 +68,8 @@ const BuilderComponentPane = ({ topOffset = 0 }) => {
6868
position: absolute;
6969
height: 100%;
7070
width: ${BUILDER_PANE_WIDTH}px;
71-
box-shadow: -4px 0 4px 0 ${rgba(theme.colorBorder, 0.1)};
71+
box-shadow: -4px 0 4px 0
72+
${tinycolor(theme.colorBorder).setAlpha(0.1).toRgbString()};
7273
background-color: ${theme.colorBgBase};
7374
`}
7475
>

superset-frontend/src/dashboard/components/nativeFilters/FilterBar/ActionButtons/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import {
2828
} from '@superset-ui/core';
2929
import { Button } from '@superset-ui/core/components';
3030
import { OPEN_FILTER_BAR_WIDTH } from 'src/dashboard/constants';
31-
import { rgba } from 'emotion-rgba';
31+
import tinycolor from 'tinycolor2';
3232
import { FilterBarOrientation } from 'src/dashboard/types';
3333
import { getFilterBarTestId } from '../utils';
3434

@@ -73,7 +73,7 @@ const verticalStyle = (theme: SupersetTheme, width: number) => css`
7373
padding-top: ${theme.sizeUnit * 6}px;
7474
7575
background: linear-gradient(
76-
${rgba(theme.colorBgLayout, 0)},
76+
${tinycolor(theme.colorBgLayout).setAlpha(0).toRgbString()},
7777
${theme.colorBgContainer} 20%
7878
);
7979

0 commit comments

Comments
 (0)