Skip to content

Conversation

msyavuz
Copy link
Member

@msyavuz msyavuz commented Jun 6, 2025

SUMMARY

Upgrade to React version 18.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Jun 6, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@msyavuz msyavuz changed the title wip: Upgrade to React 18 refactor: Upgrade to React 18 Jun 6, 2025
@msyavuz msyavuz changed the title refactor: Upgrade to React 18 refactor(wip): Upgrade to React 18 Jun 6, 2025
@msyavuz msyavuz force-pushed the msyavuz/chore/react-18 branch from 9c92f50 to c9012bc Compare June 7, 2025 10:59
@michael-s-molina
Copy link
Member

Thanks for the PR @msyavuz. We might need to rebase or update the description due to #33715.

Copy link
Contributor

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Sep 7, 2025
Copy link
Contributor

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

Copy link
Contributor

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

@michael-s-molina
Copy link
Member

@msyavuz @justinpark I don't know if this PR conflicts with #34892. Tagging you both so you can sync.

@msyavuz
Copy link
Member Author

msyavuz commented Sep 8, 2025

@michael-s-molina i don't think it does, i didn't touch any lifecycle methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants