Skip to content

fix(Context-Menu): Fixing Context Menu for Table Chart with Html Content #33791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix(Context-Menu): Fixing Context Menu for Table Chart with Html Content #33791

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f7665f
Fixing context menu with html values in table cells
amaannawab923 Jun 17, 2025
e0e1e7d
update: use superset ui core functions as per comments
amaannawab923 Aug 14, 2025
fdb3ba1
Merge branch 'master' of https://github.com/apache/superset into fix/…
amaannawab923 Aug 14, 2025
d22eb48
update: give appropriate name to function for extracting text from html
amaannawab923 Aug 14, 2025
0f51c96
update: move extract text from html to html module in superset ui / core
amaannawab923 Aug 14, 2025
b744472
update: unit tests for extract text from html
amaannawab923 Aug 15, 2025
5999f56
update: fix the codeql ci cd warning
amaannawab923 Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ import {
t,
tn,
useTheme,
isProbablyHTML,
removeHTMLTags,
SupersetTheme,
} from '@superset-ui/core';
import {
Expand Down Expand Up @@ -251,6 +253,13 @@ function SelectPageSize({
const getNoResultsMessage = (filter: string) =>
filter ? t('No matching records found') : t('No records found');

const sanitizeHtmlValue = (value: DataRecordValue): DataRecordValue => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't use the sanitizeHtml from the utils? Guessing this is different? does this function belongs in the utils or is it component-specific?

Copy link
Contributor Author

@amaannawab923 amaannawab923 Aug 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is different , its about extracting value from Html Tag ->
Input :
< /a href="https://www.google.com/search?q=United Kingdom">United Kingdom</a>"

Expected Output:
United Kingdom

Sanitise Html function would just sanitise that html to remove malicious code

For now , i guess this is component specific , because it will only come to use here in Table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the function name is causing confusion with html sanitisation , should probably rename it to , ExtractTextFromHtml

if (typeof value === 'string' && isProbablyHTML(value)) {
return removeHTMLTags(value);
}
return value;
};

export default function TableChart<D extends DataRecord = DataRecord>(
props: TableChartTransformedProps<D> & {
sticky?: DataTableProps<D>['sticky'];
Expand Down Expand Up @@ -478,7 +487,9 @@ export default function TableChart<D extends DataRecord = DataRecord>(
const drillToDetailFilters: BinaryQueryObjectFilterClause[] = [];
filteredColumnsMeta.forEach(col => {
if (!col.isMetric) {
const dataRecordValue = value[col.key];
let dataRecordValue = value[col.key];
dataRecordValue = sanitizeHtmlValue(dataRecordValue);

drillToDetailFilters.push({
col: col.key,
op: '==',
Expand All @@ -499,7 +510,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
{
col: cellPoint.key,
op: '==',
val: cellPoint.value as string | number | boolean,
val: sanitizeHtmlValue(cellPoint.value),
},
],
groupbyFieldName: 'groupby',
Expand Down
Loading