-
Notifications
You must be signed in to change notification settings - Fork 15.7k
feat(pdf): add configurable PDF compression level support #34096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
Category | Issue | Status |
---|---|---|
Default PDF compression too aggressive ▹ view | ✅ Fix detected |
Files scanned
File Path | Reviewed |
---|---|
superset-frontend/src/utils/downloadAsPdf.ts | ✅ |
superset-frontend/src/types/bootstrapTypes.ts | ✅ |
superset/views/base.py | ✅ |
superset/config.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #34096 +/- ##
===========================================
+ Coverage 60.48% 71.91% +11.42%
===========================================
Files 1931 587 -1344
Lines 76236 43467 -32769
Branches 8568 4699 -3869
===========================================
- Hits 46114 31260 -14854
+ Misses 28017 10979 -17038
+ Partials 2105 1228 -877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
re-running CI 🤞 |
Great feature, thank you! |
@rusackas Will you make a confirmation please? |
re-running CI. Ping me again (here or on Superset Slack) if it passes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but adding @sadpandajoe / @eschutho in case they have concerns for.... certain hosted SaaS services built around Superset ;)
SUMMARY
Added support for configurable PDF compression levels in Superset. The changes include:
This allows administrators to configure the balance between PDF generation speed and file size based on system requirements and user needs.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No visual changes - this is an internal performance optimization for PDF generation.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
Additional Notes: