Skip to content

Conversation

alexandrusoare
Copy link
Contributor

@alexandrusoare alexandrusoare commented Aug 7, 2025

SUMMARY

Feature for SQL Lab to use AI for text-to-sql.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

korbit-ai bot commented Aug 7, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@github-actions github-actions bot added api Related to the REST API packages labels Aug 7, 2025
@villebro
Copy link
Member

villebro commented Aug 7, 2025

Thank you for the PR. The Superset project is in the process of introducing an extension framework to make it possible to introduce this type of functionality without burdening the core codebase. Please take a look:

Once the PR has landed, contributions are welcomed to add features required for enabling this type of functionality.

@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label Aug 12, 2025
logger.info(
"Updating database %s with fields: %s",
self._model_id,
list(safe_properties.keys()),

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information High

This expression logs
sensitive data (password)
as clear text.
This expression logs
sensitive data (password)
as clear text.
This expression logs
sensitive data (password)
as clear text.
This expression logs
sensitive data (password)
as clear text.
Comment on lines +235 to +240
response = requests.post(
data["endpoint_url"],
json=test_data,
headers=headers,
timeout=timeout,
)

Check failure

Code scanning / CodeQL

Full server-side request forgery Critical

The full URL of this request depends on a
user-provided value
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API hold:sip! hold! On hold packages review:draft risk:db-migration PRs that require a DB migration size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants