Skip to content

fix(login): oauth and ldap login ignoring superset_app_root #34657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −5
Open

fix(login): oauth and ldap login ignoring superset_app_root #34657

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b126698
fix: oauth and ldap login ignoring superset_app_root
lguichard78 Aug 12, 2025
f9ed0cf
fix: oauth and ldap login ignoring superset_app_root
lguichard78 Aug 13, 2025
d2250d3
Update index.tsx
lguichard78 Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions superset-frontend/src/pages/Login/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
import { useState } from 'react';
import { capitalize } from 'lodash/fp';
import getBootstrapData from 'src/utils/getBootstrapData';
import { ensureAppRoot } from 'src/utils/pathUtils';

type OAuthProvider = {
name: string;
Expand Down Expand Up @@ -87,8 +88,9 @@ export default function Login() {

const onFinish = (values: LoginForm) => {
setLoading(true);
SupersetClient.postForm('/login/', values, '').finally(() => {
setLoading(false);
SupersetClient.postForm(ensureAppRoot('/login/'), values, '').finally(
() => {
setLoading(false);
});
};

Expand Down Expand Up @@ -126,7 +128,7 @@ export default function Login() {
{providers.map((provider: OIDProvider) => (
<Form.Item<LoginForm>>
<Button
href={`/login/${provider.name}`}
href={ensureAppRoot(`/login/${provider.name}`)}
block
iconPosition="start"
icon={getAuthIconElement(provider.name)}
Expand All @@ -144,7 +146,7 @@ export default function Login() {
{providers.map((provider: OAuthProvider) => (
<Form.Item<LoginForm>>
<Button
href={`/login/${provider.name}`}
href={ensureAppRoot(`/login/${provider.name}`)}
block
iconPosition="start"
icon={getAuthIconElement(provider.name)}
Expand Down Expand Up @@ -212,7 +214,7 @@ export default function Login() {
<Button
block
type="default"
href="/register/"
href={ensureAppRoot('/register/')}
data-test="register-button"
>
{t('Register')}
Expand Down
Loading