fix(pie): fixes pie chart other click error #35086
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Unsafe type assertion after filtering ▹ view | 🧠 Not in standard |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/plugins/plugin-chart-echarts/src/utils/eventHandlers.ts | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
+57
to
+59
| const groupbyValues = values | ||
| .map(value => labelMap[value]) | ||
| .filter(Boolean) as string[][]; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
filter(Boolean) removes any null/undefined values from the array. In this context, it prevents errors when labelMap doesn't contain an entry for the "Other" group by filtering out that undefined result before further processing.
cbum-dev
changed the title
mistercrunch
changed the title
|
Hoping @kgabryje can take a look. Looked a bit and was wondering if |
sadpandajoe
added
the
v6.0
sadpandajoe
pushed a commit
that referenced
this pull request
Sep 12, 2025
(cherry picked from commit b42060c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pie chart run time error on clicking the "other" group.
Fixes #35028
SUMMARY
The issue was caused by the event handler in eventHandlers.ts which did not account for the "Other" group not having a corresponding entry in the labelMap. This led to an attempt to access a property on an undefined value, resulting in a TypeError.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:-
After:-
TESTING INSTRUCTIONS
Create or open a dashboard with a Pie Chart, ensure an "Other" slice is generated (e.g., by lowering the Series Limit), then click both a regular slice and the "Other" slice.
Verify that regular slices support cross-filtering as expected, while clicking "Other" does not crash the app and shows no drill-down options.
ADDITIONAL INFORMATION