chore(antd): upgrade antd to 5.27.4 #35252
Draft
+61
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
9 tasks
The antd upgrade to 5.27.4 changed the Table component rendering to include duplicate column headers, causing Jest tests to fail when using findByText/getByText for table headers. Updated tests to use findAllByText/getAllByText instead. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
geido
reviewed
Sep 27, 2025
| expect(clauseColumn).toBeInTheDocument(); | ||
| expect(modifiedColumn).toBeInTheDocument(); | ||
| expect(actionsColumn).toBeInTheDocument(); | ||
| const nameColumns = await within(table).findAllByText('Name'); |
There was a problem hiding this comment.
So duplication is now getting worse with the upgrade?
There was a problem hiding this comment.
Yeah, duplication is the blocker for upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION