Skip to content

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Sep 24, 2025

Summary

This PR fixes example loading in showtime ephemeral environments by adding the missing SUPERSET__SQLALCHEMY_EXAMPLES_URI environment variable to the ECS task definition.

Problem: After the August 2025 Docker changes that added DuckDB examples support (#34831), showtime ephemeral environments stopped loading examples. The Docker build process correctly downloads the DuckDB examples file to /app/data/examples.duckdb, but the ECS task definition was missing the environment variable that tells Superset where to find this file.

Root Cause: The main repo's ECS task definition (used by showtime) wasn't updated when DuckDB examples support was added to the Docker build process. This created a disconnect between:

  • ✅ Docker build: Downloads examples.duckdb file via LOAD_EXAMPLES_DUCKDB=true
  • ❌ Runtime config: Missing SUPERSET__SQLALCHEMY_EXAMPLES_URI to locate the file

Solution: Added the DuckDB examples database URI to match the configuration used in docker-compose.yml files and the working showtime repo configuration.

Before/After

Before: Showtime ephemeral environments failed to load examples - containers had the DuckDB file but didn't know where to find it
After: Showtime environments can properly access the pre-built DuckDB examples file and load dashboards/charts

Testing Instructions

  1. Create a showtime ephemeral environment by adding the 🎪 ⚡ showtime-trigger-start label to a PR
  2. Wait for environment to deploy (look for 🎪 {sha} 🚦 running label)
  3. Access the showtime URL from the 🎪 {sha} 🌐 {ip}:8080 label
  4. Verify examples are loaded correctly in the UI
  5. Check that dashboards and charts are available in the examples section

Context: Showtime Ephemeral Environments

This change is specifically needed for the showtime system that creates ephemeral Apache Superset environments for PR testing. The showtime repo already has this configuration working, but the main Apache Superset repo's ECS task definition was missing this critical environment variable.

Without this fix, showtime environments appear to start successfully but fail to load any example data, making them less useful for testing and demonstration purposes.

Additional Information

  • Fixes examples loading in showtime ephemeral environments
  • Has associated issue:
  • Required feature flags: None
  • Changes UI: No
  • Includes DB Migration: No
  • Introduces new feature or API: No
  • Removes existing feature or API: No

🤖 Generated with Claude Code

…ronments

This adds the missing SUPERSET__SQLALCHEMY_EXAMPLES_URI environment variable
to the ECS task definition used by showtime ephemeral environments.

Without this configuration, showtime environments were unable to load examples
because the container didn't know where to find the DuckDB examples file that
was downloaded during Docker build (via LOAD_EXAMPLES_DUCKDB=true).

The URI matches what's used in docker-compose.yml and docker-compose-light.yml,
with read-only access mode for safety in ephemeral environments.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Sep 24, 2025
@dosubot dosubot bot added the data:connect:duckdb Related to a specific database label Sep 24, 2025
@eschutho eschutho added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Sep 24, 2025
@github-actions github-actions bot added 🎪 55e3da4 🚦 building Environment 55e3da4 status: building 🎪 55e3da4 📅 2025-09-24T01-26 Environment 55e3da4 created at 2025-09-24T01-26 🎪 55e3da4 ⌛ 48h Environment 55e3da4 expires after 48h and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Sep 24, 2025
Copy link
Contributor

🎪 Showtime is building environment on GHA for 55e3da4

@github-actions github-actions bot added 🎪 55e3da4 🤡 eschutho Environment 55e3da4 requested by eschutho 🎪 55e3da4 🚦 deploying Environment 55e3da4 status: deploying 🎪 55e3da4 🚦 running Environment 55e3da4 status: running 🎪 🎯 55e3da4 Active environment pointer - 55e3da4 is receiving traffic 🎪 55e3da4 🌐 54.202.144.134:8080 Environment 55e3da4 URL: http://54.202.144.134:8080 (click to visit) and removed 🎪 55e3da4 🚦 building Environment 55e3da4 status: building 🎪 55e3da4 🚦 deploying Environment 55e3da4 status: deploying 🎪 55e3da4 🚦 running Environment 55e3da4 status: running labels Sep 24, 2025
@github-actions github-actions bot removed the 🎪 🎯 55e3da4 Active environment pointer - 55e3da4 is receiving traffic label Sep 24, 2025
Copy link
Contributor

🎪 Showtime deployed environment on GHA for 55e3da4

Environment: http://54.202.144.134:8080 (admin/admin)
Lifetime: 48h auto-cleanup
Updates: New commits create fresh environments automatically

@mistercrunch mistercrunch added the 🎪 🎯 55e3da4 Active environment pointer - 55e3da4 is receiving traffic label Sep 24, 2025
"value": "False"
},
{
"name": "SUPERSET__SQLALCHEMY_EXAMPLES_URI",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file isn't used for showtime, only for old eph envs, in showtime equivalent file is here https://github.com/mistercrunch/superset-showtime/blob/main/showtime/data/ecs-task-definition.json#L36-L37

@eschutho
Copy link
Member Author

Closing this PR as mistercrunch pointed out that this file isn't used by showtime - only by the old ephemeral environments. Showtime uses its own ECS task definition from the superset-showtime repository. Will investigate the actual showtime issue separately.

@eschutho eschutho closed this Sep 24, 2025
@github-actions github-actions bot removed 🎪 🎯 55e3da4 Active environment pointer - 55e3da4 is receiving traffic 🎪 55e3da4 ⌛ 48h Environment 55e3da4 expires after 48h 🎪 55e3da4 🤡 eschutho Environment 55e3da4 requested by eschutho 🎪 55e3da4 🚦 running Environment 55e3da4 status: running 🎪 55e3da4 🌐 54.202.144.134:8080 Environment 55e3da4 URL: http://54.202.144.134:8080 (click to visit) 🎪 55e3da4 📅 2025-09-24T01-26 Environment 55e3da4 created at 2025-09-24T01-26 labels Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect:duckdb Related to a specific database github_actions Pull requests that update GitHub Actions code preset-io size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants