-
Notifications
You must be signed in to change notification settings - Fork 15.7k
fix: Add DuckDB examples URI to ECS task definition for showtime environments #35258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ronments This adds the missing SUPERSET__SQLALCHEMY_EXAMPLES_URI environment variable to the ECS task definition used by showtime ephemeral environments. Without this configuration, showtime environments were unable to load examples because the container didn't know where to find the DuckDB examples file that was downloaded during Docker build (via LOAD_EXAMPLES_DUCKDB=true). The URI matches what's used in docker-compose.yml and docker-compose-light.yml, with read-only access mode for safety in ephemeral environments. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎪 Showtime deployed environment on GHA for 55e3da4 • Environment: http://54.202.144.134:8080 (admin/admin) |
"value": "False" | ||
}, | ||
{ | ||
"name": "SUPERSET__SQLALCHEMY_EXAMPLES_URI", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file isn't used for showtime, only for old eph envs, in showtime equivalent file is here https://github.com/mistercrunch/superset-showtime/blob/main/showtime/data/ecs-task-definition.json#L36-L37
Closing this PR as mistercrunch pointed out that this file isn't used by showtime - only by the old ephemeral environments. Showtime uses its own ECS task definition from the superset-showtime repository. Will investigate the actual showtime issue separately. |
Summary
This PR fixes example loading in showtime ephemeral environments by adding the missing
SUPERSET__SQLALCHEMY_EXAMPLES_URI
environment variable to the ECS task definition.Problem: After the August 2025 Docker changes that added DuckDB examples support (#34831), showtime ephemeral environments stopped loading examples. The Docker build process correctly downloads the DuckDB examples file to
/app/data/examples.duckdb
, but the ECS task definition was missing the environment variable that tells Superset where to find this file.Root Cause: The main repo's ECS task definition (used by showtime) wasn't updated when DuckDB examples support was added to the Docker build process. This created a disconnect between:
LOAD_EXAMPLES_DUCKDB=true
SUPERSET__SQLALCHEMY_EXAMPLES_URI
to locate the fileSolution: Added the DuckDB examples database URI to match the configuration used in docker-compose.yml files and the working showtime repo configuration.
Before/After
Before: Showtime ephemeral environments failed to load examples - containers had the DuckDB file but didn't know where to find it
After: Showtime environments can properly access the pre-built DuckDB examples file and load dashboards/charts
Testing Instructions
🎪 ⚡ showtime-trigger-start
label to a PR🎪 {sha} 🚦 running
label)🎪 {sha} 🌐 {ip}:8080
labelContext: Showtime Ephemeral Environments
This change is specifically needed for the showtime system that creates ephemeral Apache Superset environments for PR testing. The showtime repo already has this configuration working, but the main Apache Superset repo's ECS task definition was missing this critical environment variable.
Without this fix, showtime environments appear to start successfully but fail to load any example data, making them less useful for testing and demonstration purposes.
Additional Information
🤖 Generated with Claude Code