feat(frontend): add dataset cache clearing utilities and integration #35264
+94
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add datasetCache utility with functions to clear cached API responses - Integrate cache clearing in SaveDatasetModal after dataset updates - Integrate cache clearing in DatasourceModal and DatasourceEditor - Ensures fresh data is fetched after dataset modifications 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
dosubot
bot
added
change:frontend
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Redundant and imprecise cache key matching ▹ view | 🧠 Not in standard |
|
Invalid dataset ID 0 rejected by falsy check ▹ view | 🧠 Not in scope |
 |
Inefficient Two-Pass Cache Operation ▹ view | 🧠 Incorrect |
|
Unawaited dataset cache clear ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/utils/datasetCache.ts | ✅ |
| superset-frontend/src/components/Datasource/DatasourceModal/index.tsx | ✅ |
| superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx | ✅ |
| superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
+28
to
+48
| export function clearDatasetCache(datasetId: number | string): void { | ||
| if (!datasetId) return; | ||
|
|
||
| const keysToDelete: string[] = []; | ||
|
|
||
| // Find all cache keys related to this dataset | ||
| supersetGetCache.forEach((_value, key) => { | ||
| // Match any endpoint that references this dataset ID | ||
| // This includes: | ||
| // - /api/v1/dataset/{id} | ||
| // - /api/v1/dataset/{id}?q=... | ||
| // - /api/v1/dataset/{id}/related_objects | ||
| // - etc. | ||
| if ( | ||
| key.includes(`/api/v1/dataset/${datasetId}`) || | ||
| key.includes(`/api/v1/dataset/${datasetId}/`) || | ||
| key.includes(`/api/v1/dataset/${datasetId}?`) | ||
| ) { | ||
| keysToDelete.push(key); | ||
| } | ||
| }); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
+41
to
+45
| if ( | ||
| key.includes(`/api/v1/dataset/${datasetId}`) || | ||
| key.includes(`/api/v1/dataset/${datasetId}/`) || | ||
| key.includes(`/api/v1/dataset/${datasetId}?`) | ||
| ) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| * @param datasetId - The ID of the dataset to clear from cache | ||
| */ | ||
| export function clearDatasetCache(datasetId: number | string): void { | ||
| if (!datasetId) return; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
|
||
| // Clear the dataset cache to ensure fresh data when fetching columns for filters | ||
| // This ensures that changes to the dataset are immediately reflected | ||
| clearDatasetCache(currentDatasource.id); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Implements dataset cache clearing functionality to ensure fresh data is fetched after dataset modifications. This addresses potential stale data issues where cached API responses were not being invalidated when datasets were updated.
Key Changes:
datasetCache.tsutility with functions to clear cached API responses for specific datasetsSaveDatasetModalafter dataset updatesDatasourceModalandDatasourceEditorcomponentsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - This is a backend caching improvement with no visible UI changes
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
🤖 Generated with Claude Code