Skip to content

fix: Enable DuckDB examples loading in showtime ephemeral environments #35294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: Enable DuckDB examples loading in showtime ephemeral environments #35294

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
55e3da4
fix: Add DuckDB examples URI to ECS task definition for showtime envi…
eschutho Sep 24, 2025
b2129b4
fix: Move LOAD_EXAMPLES_DUCKDB ARG to global scope in Dockerfile
eschutho Sep 24, 2025
482b710
Revert "fix: Add DuckDB examples URI to ECS task definition for showt…
eschutho Sep 25, 2025
1772412
fix: Use DuckDB versions that match known-working motherduck config
eschutho Sep 26, 2025
71e4fcf
fix: Use version ranges for DuckDB dependencies
eschutho Sep 26, 2025
ecfedd4
fix: Only constrain duckdb core, keep duckdb-engine current
eschutho Sep 26, 2025
8ae41ba
docs: Add comment explaining DuckDB version constraint
eschutho Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ecs-task-definition.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@
{
"name": "TALISMAN_ENABLED",
"value": "False"
},
{
"name": "SUPERSET__SQLALCHEMY_EXAMPLES_URI",
"value": "duckdb:////app/data/examples.duckdb?access_mode=read_only"
}
],
"mountPoints": [],
Expand Down
7 changes: 5 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ ARG BUILDPLATFORM=${BUILDPLATFORM:-amd64}
# Include translations in the final build
ARG BUILD_TRANSLATIONS="false"

# Build arg to pre-populate examples DuckDB file
ARG LOAD_EXAMPLES_DUCKDB="false"

######################################################################
# superset-node-ci used as a base for building frontend assets and CI
######################################################################
Expand Down Expand Up @@ -143,8 +146,8 @@ RUN if [ "${BUILD_TRANSLATIONS}" = "true" ]; then \
######################################################################
FROM python-base AS python-common

# Build arg to pre-populate examples DuckDB file
ARG LOAD_EXAMPLES_DUCKDB="false"
# Re-declare build arg to receive it in this stage
ARG LOAD_EXAMPLES_DUCKDB

ENV SUPERSET_HOME="/app/superset_home" \
HOME="/app/superset_home" \
Expand Down
Loading