Skip to content

Conversation

gabotorresruiz
Copy link
Contributor

SUMMARY

Fixed an issue where the bottom half of the SQL Lab left panel was appearing blank. The problem was caused by improper height calculations using fixed pixel values instead of flexbox layout. The component was using a hardcoded height prop (defaulting to 500px) and calculating the table area as height - 130px, which left empty space at the bottom

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image (4)

After:
image

TESTING INSTRUCTIONS

  1. Open SQL Lab
  2. Select a database and schema in the left panel
  3. Add some tables to view their columns
  4. Verify that the left panel properly fills the entire height without blank space at the bottom
  5. Test resizing the browser window to ensure the layout remains responsive
  6. Switch between different databases/schemas to ensure the layout remains consistent

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend sqllab Namespace | Anything related to the SQL Lab labels Sep 26, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
superset-frontend/src/SqlLab/components/SqlEditor/index.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Contributor

⚠️ DEPRECATED WORKFLOW ⚠️

@geido This workflow is deprecated! Please use the new Superset Showtime system instead:

Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

Copy link
Contributor

@geido Ephemeral environment spinning up at http://35.94.228.194:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit 784ff82 into apache:master Sep 26, 2025
81 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend size/M sqllab Namespace | Anything related to the SQL Lab testenv-up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants