Skip to content

Add an async Aptabase.flush() #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add an async Aptabase.flush() #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/Aptabase/Aptabase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,18 @@ public class Aptabase: NSObject {
enqueueEvent(eventName, with: codable)
}

/// Forces all queued events to be sent to the server
/// Forces all queued events to be sent to the server asynchronously. Returns before the events have been sent.
@objc public func flush() {
Task {
await self.client?.flush()
}
}

/// Forces all queued events to be sent to the server. Returns after the events have been sent.
public func flush() async {
await self.client?.flush()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
await self.client?.flush()
await client?.flush()

}

private func enqueueEvent(_ eventName: String, with props: [String: AnyCodableValue] = [:]) {
guard let client else {
return
Expand Down