Automate RLS dataset cretion#373
Open
vmindru wants to merge 12 commits intoaws-solutions-library-samples:mainfrom
Open
Automate RLS dataset cretion#373vmindru wants to merge 12 commits intoaws-solutions-library-samples:mainfrom
vmindru wants to merge 12 commits intoaws-solutions-library-samples:mainfrom
Conversation
iakov-gan
reviewed
Jun 30, 2025
iakov-gan
reviewed
Jun 30, 2025
iakov-gan
reviewed
Jun 30, 2025
Co-authored-by: Iakov GAN <82834333+iakov-aws@users.noreply.github.com>
Co-authored-by: Iakov GAN <82834333+iakov-aws@users.noreply.github.com>
Co-authored-by: Iakov GAN <82834333+iakov-aws@users.noreply.github.com>
iakov-gan
reviewed
Jul 11, 2025
Contributor
Author
|
No
Best Regards
Mindru Veaceslav
***@***.***
…On Fri, Jul 11, 2025, 23:00 Iakov GAN ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In rls/deploy/deploy_cid_rls.yaml
<#373 (comment)>
:
> + Actions:
+ - quicksight:PassDataSource
+ - quicksight:DescribeDataSourcePermissions
+ - quicksight:UpdateDataSource
+ - quicksight:UpdateDataSourcePermissions
+ - quicksight:DescribeDataSource
+ - quicksight:DeleteDataSource
+
+ CidRlsDataSet:
+ Type: AWS::QuickSight::DataSet
+ DependsOn: CidRlsDataSource
+ Properties:
+ AwsAccountId: !Ref AWS::AccountId
+ DataSetId: cid_rls
+ Name: cid_rls
+ ImportMode: DIRECT_QUERY
can it be spice?
—
Reply to this email directly, view it on GitHub
<#373 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABYBK3KI5PU47S4I2V57WGT3IAQWJAVCNFSM6AAAAACAOBCCX6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMJRHE3DQNRWGM>
.
You are receiving this because you authored the thread.Message ID:
<aws-solutions-library-samples/cloud-intelligence-dashboards-data-collection/pull/373/review/3011968663
@github.com>
|
Contributor
Author
|
There is a issue with spice dataset rule creation fails with unknown
internal error.
Best Regards
Mindru Veaceslav
***@***.***
…On Fri, Jul 11, 2025, 23:27 Veaceslav Mindru ***@***.***> wrote:
No
Best Regards
Mindru Veaceslav
***@***.***
On Fri, Jul 11, 2025, 23:00 Iakov GAN ***@***.***> wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In rls/deploy/deploy_cid_rls.yaml
> <#373 (comment)>
> :
>
> > + Actions:
> + - quicksight:PassDataSource
> + - quicksight:DescribeDataSourcePermissions
> + - quicksight:UpdateDataSource
> + - quicksight:UpdateDataSourcePermissions
> + - quicksight:DescribeDataSource
> + - quicksight:DeleteDataSource
> +
> + CidRlsDataSet:
> + Type: AWS::QuickSight::DataSet
> + DependsOn: CidRlsDataSource
> + Properties:
> + AwsAccountId: !Ref AWS::AccountId
> + DataSetId: cid_rls
> + Name: cid_rls
> + ImportMode: DIRECT_QUERY
>
> can it be spice?
>
> —
> Reply to this email directly, view it on GitHub
> <#373 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABYBK3KI5PU47S4I2V57WGT3IAQWJAVCNFSM6AAAAACAOBCCX6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMJRHE3DQNRWGM>
> .
> You are receiving this because you authored the thread.Message ID:
> <aws-solutions-library-samples/cloud-intelligence-dashboards-data-collection/pull/373/review/3011968663
> @github.com>
>
|
iakov-gan
approved these changes
Aug 25, 2025
Contributor
iakov-gan
suggested changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.