fix(credential_provider): Increase RoleSessionName truncation limit to preserve full UUIDs#205
Open
seeinyou wants to merge 1 commit intoaws-solutions-library-samples:mainfrom
Conversation
…o preserve full UUIDs The sub claim was truncated to 32 characters, cutting off the last 4 characters of standard UUIDs (36 chars). This made it impossible to correlate CloudTrail and CloudWatch log entries back to specific IdP users. Increase the limit from 32 to 52 characters (64-char AWS limit minus 12-char "claude-code-" prefix) for both the sub and email fallback paths. Closes aws-solutions-library-samples#204
Contributor
|
LGTM |
dineshSajwan
reviewed
Apr 8, 2026
Contributor
dineshSajwan
left a comment
dineshSajwan
left a comment
There was a problem hiding this comment.
Thank you for the fix, It looks all good to me. I think we should add a test coverage for these new limits .
- test case for
RoleSessionNamelength - test case for IdP sub claim length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #204