Skip to content

Define list of modules to skip#6953

Merged
davidh44 merged 4 commits into
masterfrom
hdavidh/modules-to-skip
May 14, 2026
Merged

Define list of modules to skip#6953
davidh44 merged 4 commits into
masterfrom
hdavidh/modules-to-skip

Conversation

@davidh44

@davidh44 davidh44 commented May 11, 2026

Copy link
Copy Markdown
Contributor

Motivation and Context

Create single source of truth for the list of modules to skip, for maven publishing and docs generation

  • buildspecs/release-to-maven.yml and buildspecs/release-javadoc.yml were recently removed from SDK repo
    • These specs had hardcoded list MODULES_TO_SKIP
  • Github CI workflow new-module-verification.yml checks new test modules against MODULES_TO_SKIP
  • manually triggered scripts/setup-new-module updates MODULES_TO_SKIP

Modifications

  • buildspecs/resources/test-modules-publish-allowlist.txt: 5 test modules intentionally published to Maven Central (bundle-logging-bridge-binding-test, http-client-tests, ruleset-testing-core, service-test-utils, test-utils), keeps existing behavior
  • buildspecs/resources/generate-modules-to-skip.sh: script that generates module exclusion list at runtime, includes /test modules
  • .github/workflows/new-module-verification.yml: updated to inform whether a new test module is in the allowlist or will be auto-skipped
  • scripts/setup-new-module: update_buildspecs() now prompts whether the new module should be published to Maven, and appends to the allowlist if yes.

@davidh44
davidh44 requested a review from a team as a code owner May 11, 2026 20:17
Comment thread buildspecs/resources/modules-to-skip.txt Outdated
Comment thread buildspecs/resources/generate-modules-to-skip.sh
Comment thread buildspecs/resources/generate-modules-to-skip.sh Outdated
Comment thread buildspecs/resources/generate-modules-to-skip.sh
@davidh44
davidh44 added this pull request to the merge queue May 14, 2026
Merged via the queue into master with commit 0c5e331 May 14, 2026
12 of 13 checks passed
@github-actions

Copy link
Copy Markdown

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 14, 2026
@davidh44
davidh44 deleted the hdavidh/modules-to-skip branch May 14, 2026 23:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants