Remove Netty UnpooledByteBufAllocator workaround#6968
Merged
Conversation
If using the JDK SSL provider with Netty, we currently switch away from Netty's default ByteBuffer allocator to the unpooled allocator, to work around a regression in Netty 4.1.43 - netty/netty#9768. This has been fixed in later versions, so we should revert back to using the default. This is essentially a revert of the relevant parts of a72f494. Reduces allocation rate on NettyHttpClientH1Benchmark by around 45% when using the JDK SSL provider.
zoewangg
reviewed
May 14, 2026
zoewangg
left a comment
zoewangg
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Let's run anticanary to double check before merging
zoewangg
approved these changes
May 15, 2026
Contributor
Author
Ran a 30-min canary, 7.4% less memory used, ~5% less CPU, download latency dropped 8-9%, throughput up slightly. |
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
zoewangg
added
the
perf-improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License