Fix SdkPlugins being able to set a region, but the SdkClient's crashing without region anyways.#7177
Open
Techno3d wants to merge 5 commits into
Open
Fix SdkPlugins being able to set a region, but the SdkClient's crashing without region anyways.#7177Techno3d wants to merge 5 commits into
Techno3d wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is a fix for #7151.
SdkPluginswere invoked after region resolution happened, which led to a bug where if theSdkPluginwas the only thing setting a region, theSdkClientwould not build, instead throwing anSdkClientExceptiondue to not being able to resolve a region.Modifications
This PR changes
SdkDefaultClientBuilderso thatSdkPluginsare invoked before the region is resolved, modifyingsyncClientConfigurationandasyncClientConfiguration.Testing
I've added a test to
SdkPluginTestthat checks if theProtocolRestJsonClientcan be built and the region is set correctly. I did not add this test to the regulartestCaseslist because the defaultClient sets a Region of US_WEST_2, and I could not uncouple that without tests breaking. I've also tested this on my own project that was using an SdkPlugin to set region (among other settings), and it now works without throwing a SdkClientException.Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License